Skip to content

docs: fix string interpolation and update comments#13261

Merged
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-07-04
Jul 4, 2026
Merged

docs: fix string interpolation and update comments#13261
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-07-04

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes surfaced by an automated review of the 38 commits merged to develop between c157a0d (2026-07-03 17:39 -0500) and 8975f00 (2026-07-04 06:03 -0500). Three high-signal issues survived filtering; each is grouped as its own commit by package:

  • number/int64/ctortest.ts (docs/types/test.ts) line 42: stray fourth period on the ellipsis, .... instead of .... Fix the typo. Introduced in 8d10f98b.
  • number/uint64/base/number2words@returns tag in number2words/lib/main.js:32 says {Array<uinteger32>}; should be {Array<number>} per every other to-words/number2words package and the package's own docs/types/index.d.ts. uinteger32 doesn't exist anywhere else in stdlib. From 3684ccc6.
  • stats/base/dists/tukey-lambda/mode%lf isn't a valid specifier for @stdlib/string/format; copy-pasted from the C example in f52a4633. Replace with %0.4f in lib/node_modules/@stdlib/stats/base/dists/tukey-lambda/mode/examples/index.js:30 and README.md:102, matching every other dist package (e.g. pareto-type1/mode).

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. Four independent reviewer agents audited the union diff (266 files, 13,496 insertions across 38 commits) against docs/style-guides/ and peer packages:

  • 2 style-compliance reviewers (Sonnet) — parallel, independent
  • 2 bug hunters (Opus) — parallel, independent, restricted to defects fully visible within the diff window

Excluded. Issues that would require behavior changes outside a mechanical typo/JSDoc-convention fix, that only one agent flagged and could not be independently re-verified from the diff, or that fell outside the diff window. One candidate — stats/base/dists/log-logistic/mean returning NaN for beta <= 1 where peer packages (pareto-type1/mean, frechet/mean, levy/mean) return +Infinity for divergent means — was left off this PR because it crosses from mechanical fix into a behavior change on a newly-added package and warrants maintainer discussion before landing.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Automated review harness authored the fixes. Four independent reviewer agents scanned the 24-hour commit window; findings that only one agent surfaced and could not be independently re-verified from the diff were dropped. Human maintainer to promote from draft after audit.


@stdlib-js/reviewers


Generated by Claude Code

@stdlib-bot

stdlib-bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
number/int64/ctor $\\color{red}603/685$
$\\color{green}+0.00\\%$
$\\color{red}51/55$
$\\color{green}+0.00\\%$
$\\color{red}9/11$
$\\color{green}+0.00\\%$
$\\color{red}603/685$
$\\color{green}+0.00\\%$
number/uint64/base/number2words $\\color{green}162/162$
$\\color{green}+0.00\\%$
$\\color{green}5/5$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}162/162$
$\\color{green}+0.00\\%$
stats/base/dists/tukey-lambda/mode $\\color{green}158/158$
$\\color{green}+0.00\\%$
$\\color{green}7/7$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}158/158$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Comment thread lib/node_modules/@stdlib/number/uint64/base/number2words/lib/main.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte marked this pull request as ready for review July 4, 2026 21:18
@kgryte kgryte requested a review from a team July 4, 2026 21:18
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 4, 2026
@kgryte kgryte changed the title docs: follow-up fixes for commits merged to develop on 2026-07-04 docs: fix string interpolation and update comments Jul 4, 2026
@kgryte kgryte merged commit 4e24379 into develop Jul 4, 2026
32 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-07-04 branch July 4, 2026 21:22
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants